Extract rule tester initiation

atfzl · Sep 27, 2023 · 602aa65 · 602aa65
1 parent 82730a0
commit 602aa65
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 47 deletions.
diff --git a/test/lib/rules/no-undef-class.test.js b/test/lib/rules/no-undef-class.test.js
@@ -1,26 +1,7 @@
-import { RuleTester } from 'eslint';
-import { test } from 'mocha';
-
 import rule from '../../../lib/rules/no-undef-class';
+import { RuleTester, addFilenameOption } from '../../utils';
 
-import { addFilenameOption } from '../../utils';
-
-RuleTester.describe = function (text, method) {
-  RuleTester.it.title = text;
-  return method.call(this);
-};
-
-RuleTester.it = function (text, method) {
-  test(RuleTester.it.title + ': ' + text, method);
-};
-
-const ruleTester = new RuleTester({
-  parserOptions: {
-    sourceType: 'module',
-    ecmaVersion: 6,
-    ecmaFeatures: { jsx: true },
-  },
-});
+const ruleTester = new RuleTester();
 
 ruleTester.run('no-undef-class', rule, {
   valid: [

diff --git a/test/lib/rules/no-unused-class.test.js b/test/lib/rules/no-unused-class.test.js
@@ -1,26 +1,7 @@
-import { RuleTester } from 'eslint';
-import mocha from 'mocha';
-
 import rule from '../../../lib/rules/no-unused-class';
+import { RuleTester, addFilenameOption } from '../../utils';
 
-import { addFilenameOption } from '../../utils';
-
-RuleTester.describe = function (text, method) {
-  RuleTester.it.title = text;
-  return method.call(this);
-};
-
-RuleTester.it = function (text, method) {
-  mocha.test(RuleTester.it.title + ': ' + text, method);
-};
-
-const ruleTester = new RuleTester({
-  parserOptions: {
-    sourceType: 'module',
-    ecmaVersion: 6,
-    ecmaFeatures: { jsx: true },
-  },
-});
+const ruleTester = new RuleTester();
 
 ruleTester.run('no-unused-class', rule, {
   valid: [

diff --git a/test/utils.js b/test/utils.js
@@ -1,13 +1,36 @@
-/* pattern taken from eslint-plugin-import */
-
 import path from 'path';
+import { RuleTester as EslintRuleTester } from 'eslint';
+import { test } from 'mocha';
 
-/**
- * TODO:  Find a way to remove this.
- */
+/* pattern taken from eslint-plugin-import */
 export function addFilenameOption(testCase) {
   return {
     ...testCase,
+    // TODO:  Find a way to remove this.
     filename: path.resolve(__dirname, './files/foo.js'),
   };
 }
+
+
+/**
+ * Customizing ESLint rule tester to be run by Mocha.
+ * @see https://eslint.org/docs/latest/integrate/nodejs-api#customizing-ruletester
+ */
+EslintRuleTester.describe = (text, method) => {
+  EslintRuleTester.it.title = text;
+  return method.call(this);
+};
+
+EslintRuleTester.it = (text, method) => {
+  test(EslintRuleTester.it.title + ': ' + text, method);
+};
+
+export const RuleTester = () => {
+  return new EslintRuleTester({
+    parserOptions: {
+      sourceType: 'module',
+      ecmaVersion: 6,
+      ecmaFeatures: { jsx: true },
+    },
+  });
+};