Update dependency gonzales #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhsianw
force-pushed
the
frankwang/update-dependency-gonzales
branch
from
36e8ea2 to
d361f8e
Compare
yuhsianw
force-pushed
the
frankwang/update-dependency-gonzales
branch
from
d361f8e to
982b549
Compare
yuhsianw
force-pushed
the
frankwang/update-dependency-gonzales
branch
from
982b549 to
9cdf401
Compare
| export default { | ||
| parse: (...args) => { | ||
| try { | ||
| return gonzales.parse(...args); | ||
| } catch (e) { | ||
| try { | ||
| return gonzalesPrimitive.parse(...args); |
There was a problem hiding this comment.
It's mentioned in the PR description:
Update gonzales-pe to v4.3.0 which fixed a parsing bug and more.
Remove gonzales-primitives that was previously added as a bandaid for that parsing bug.
There was a problem hiding this comment.
Thanks, Steve. To elaborate on that:
gonzalesPrimitive is an old gonzales-pe version build that was added by the previous maintainer, possibly to address some bugs introduced in the version of gonzales-pe used at that time (v4.0.3).
With the latest version gonzales-pe v4.3.0, a lot of bugs were fixed and the test case added was no longer failing. Therefore, I'm removing this fallback after upgrading to v4.3.0.
stevemorin
approved these changes
Sep 28, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
gonzales-peto v4.3.0 which fixed a parsing bug and more.gonzales-primitivesthat was previously added as a bandaid for that parsing bug.