Update dependencies #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhsianw
changed the base branch from
master
to
frankwang/update-test-runners
| @@ -3,7 +3,7 @@ import { RuleTester as EslintRuleTester } from 'eslint'; | |||
| import { test } from 'mocha'; | |||
|
|
|||
| /* pattern taken from eslint-plugin-import */ | |||
| export function addFilenameOption(testCase) { | |||
| export function addFilenameOption (testCase) { | |||
There was a problem hiding this comment.
A linter made you add a whitespace here?! That's odd 🤔
There was a problem hiding this comment.
That's a rule in the eslint-plugin-standard preset. Planning on changing the style later though.
yuhsianw
force-pushed
the
frankwang/update-test-runners
branch
from
b9add69 to
7581b2e
Compare
yuhsianw
force-pushed
the
frankwang/update-dependencies
branch
from
7e1931c to
1a766ae
Compare
yuhsianw
force-pushed
the
frankwang/update-dependencies
branch
from
1a766ae to
7402c25
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all
install,lint,test, andbuildwarnings & errors ✨Changes: