New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

allow to publish raw data - fixes #3 #4

Merged

atheriel merged 4 commits into atheriel:master from dselivanov:master

Feb 10, 2020

Contributor

dselivanov commented Feb 5, 2020

No description provided.


          allow to publish raw data - fixes atheriel#3

b22f886

atheriel reviewed

View reviewed changes

R/basic.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

R/basic.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

R/basic.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

tests/testthat/test-publish.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

tests/testthat/test-publish.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

tests/testthat/test-publish.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

tests/testthat/test-publish.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

tests/testthat/test-publish.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

R/basic.R Outdated Show resolved Hide resolved

atheriel reviewed

View reviewed changes

R/basic.R Outdated Show resolved Hide resolved

Owner

atheriel commented Feb 6, 2020

I thought I had implemented this already, definitely an error on my part. Thanks for the submission.

atheriel added the enhancement label


          address the issues from the comments to a PR

fbdf231

Contributor Author

dselivanov commented Feb 7, 2020

@atheriel thanks for valuable comments

Contributor Author

dselivanov commented Feb 7, 2020

However now I think library should produce error, not a warning when the character body length is not equal to one. For interactive use warning would be 'okay'. But for non-interactive use it is better to fail fast rather than spending a lot of time on debug later (I believe in most of the cases this package will be used in non-interactive mode)


          producers throws an error instead of warning when body is a character…

a1f2c40

… with lengt not equal to one

atheriel reviewed

View reviewed changes

man/amqp_publish.Rd Outdated Show resolved Hide resolved


          - regenerate docs

7886a57

atheriel merged commit fa11699 into atheriel:master

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels