Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix alignment for file sizes #224

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Fix alignment for file sizes #224

merged 1 commit into from
Oct 15, 2018

Conversation

jmks
Copy link
Contributor

@jmks jmks commented Oct 13, 2018

Description

File size can be up to 1023 B/KiB/etc.
The simplest solution is to allow 4 characters for alignment.

Before:

  rw-r--r--  somebody  staff  143 KiB  Sat Oct 13 14:27:58 2018    Visual_SQL_JOINS_orig.jpg
  rw-r--r--  somebody  staff  1021 B    Sat Oct 13 14:29:01 2018    a-file
  rw-r--r--  somebody  staff    0 B    Tue Nov  7 02:02:07 2017    a.md
  rw-r--r--  somebody  staff    0 B    Tue Nov  7 02:02:03 2017    a.txt
  rwxr-xr-x  somebody  staff  170 B    Tue Nov  7 02:02:02 2017    symlinks/
  rw-r--r--  somebody  staff  447 B    Tue Nov  7 02:02:04 2017    z-file
  rw-r--r--  somebody  staff    0 B    Tue Nov  7 02:02:06 2017    z.txt

After:

  rw-r--r--  somebody  staff   143 KiB   Sat Oct 13 14:27:58 2018    Visual_SQL_JOINS_orig.jpg
  rw-r--r--  somebody  staff  1021 B     Sat Oct 13 14:29:01 2018    a-file
  rw-r--r--  somebody  staff     0 B     Tue Nov  7 02:02:07 2017    a.md
  rw-r--r--  somebody  staff     0 B     Tue Nov  7 02:02:03 2017    a.txt
  rwxr-xr-x  somebody  staff   170 B     Tue Nov  7 02:02:02 2017    symlinks/
  rw-r--r--  somebody  staff   447 B     Tue Nov  7 02:02:04 2017    z-file
  rw-r--r--  somebody  staff     0 B     Tue Nov  7 02:02:06 2017    z.txt

Note that the digits for the size of a-file is now properly aligned.

File size can be up to 1023 B/KiB/etc.
The simplest solution is to allow 4 characters for alignment.
@avdv avdv merged commit de0a704 into athityakumar:master Oct 15, 2018
@avdv
Copy link
Collaborator

avdv commented Oct 15, 2018

Thank you @jmks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants