Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix exception when permission denied on symlinks #340

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

avdv
Copy link
Collaborator

@avdv avdv commented Jan 31, 2020

Description

Thanks for contributing this Pull Request. Add a brief description of what this Pull Request does. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to support your changes.

Sorry, no test case as I failed to stub File.readlink successfully.

@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #340 into master will decrease coverage by 0.31%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   89.06%   88.75%   -0.32%     
==========================================
  Files           8        8              
  Lines         494      498       +4     
==========================================
+ Hits          440      442       +2     
- Misses         54       56       +2
Impacted Files Coverage Δ
lib/colorls/core.rb 89.4% <0%> (-0.42%) ⬇️
lib/colorls/fileinfo.rb 77.77% <50%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f451476...6b2cbdc. Read the comment docs.

@avdv avdv merged commit e4a8098 into athityakumar:master Jan 31, 2020
@avdv avdv deleted the fix-338 branch January 31, 2020 08:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants