Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

case-insensitive directory matching #348

Merged
merged 1 commit into from
Mar 17, 2020
Merged

case-insensitive directory matching #348

merged 1 commit into from
Mar 17, 2020

Conversation

maxwellainatchi
Copy link
Contributor

Description

Thanks for contributing this Pull Request. Add a brief description of what this Pull Request does. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to support your changes.

Check the configuration for directories case-insensitively, matching the behavior for files.

  • Relevant Issues : Case insensitive directory matching #325
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

Check directories case-insensitively, per #325
@codecov-io
Copy link

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files           8        8           
  Lines         498      498           
=======================================
  Hits          442      442           
  Misses         56       56
Impacted Files Coverage Δ
lib/colorls/core.rb 89.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2c3c3...8b6ba5e. Read the comment docs.

Copy link
Owner

@athityakumar athityakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing! 👍

@athityakumar athityakumar merged commit ea2cc0f into athityakumar:master Mar 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants