Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing require 'set' #372

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Add missing require 'set' #372

merged 1 commit into from
Jul 7, 2020

Conversation

avdv
Copy link
Collaborator

@avdv avdv commented Jul 7, 2020

Fixes #371

Description

Thanks for contributing this Pull Request. Add a brief description of what this Pull Request does. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to support your changes.

  • Relevant Issues : colorls --git-status crashes with traceback #371
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #372 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   88.02%   88.04%   +0.02%     
==========================================
  Files           8        8              
  Lines         501      502       +1     
==========================================
+ Hits          441      442       +1     
  Misses         60       60              
Impacted Files Coverage Δ
lib/colorls/git.rb 73.33% <100.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed892e...f27048b. Read the comment docs.

@xbjfk
Copy link

xbjfk commented Jul 7, 2020

I applied this patch, and the crash was gone. Thank you :)

@avdv avdv merged commit 4d4461e into athityakumar:master Jul 7, 2020
@avdv avdv deleted the require-set branch July 7, 2020 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colorls --git-status crashes with traceback
3 participants