Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update rubocop requirement from ~> 1.38.0 to ~> 1.39.0 #556

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 14, 2022

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.39

New features

Bug fixes

  • #11150: Improve Style/RedundantRegexpEscape to catch unnecessarily escaped hyphens within a character class. (@​si-lens)
  • #11168: Fix an incorrect autocorrect for Style/ClassEqualityComparison when using instance variable comparison in module. (@​koic)
  • #11176: Fix a false positive cases for Lint/DuplicateMethods when using duplicate nested method. (@​koic)
  • #11164: Suppress "RuboCop server starting..." message with --server --format json. (@​koic)
  • #11156: Fix Style/OperatorMethodCall autocorrection when operators are chained. (@​gsamokovarov)
  • #11139: Fix a false negative for Style/HashEachMethods when using each with a symbol proc argument. (@​ydah)
  • #11161: Fix a false positive for Style/HashAsLastArrayItem when using double splat operator. (@​koic)
  • #11151: Fix a false positive for Lint/SuppressedException. (@​akihikodaki)
  • #11123: Fix autocorrection bug for Style/StringLiterals when using multiple escape characters. (@​si-lens)
  • #11165: Fix a false positive for Style/RedundantEach when any method is used between methods containing each in the method name. (@​koic)
  • #11177: Fix a false positive for Style/ObjectThen cop with TargetRubyVersion < 2.6. (@​epaew)
  • #11173: Fix an incorrect autocorrect for Style/CollectionCompact when using reject with block pass arg and no parentheses. (@​koic)
  • #11137: Fix a false positive for Style/RedundantEach when using a symbol proc argument. (@​ydah)
  • #11142: Fix Style/RedundantEach for non-chained each_ calls. (@​fatkodima)

Changes

Changelog

Sourced from rubocop's changelog.

1.39.0 (2022-11-14)

New features

Bug fixes

  • #11150: Improve Style/RedundantRegexpEscape to catch unnecessarily escaped hyphens within a character class. ([@​si-lens][])
  • #11168: Fix an incorrect autocorrect for Style/ClassEqualityComparison when using instance variable comparison in module. ([@​koic][])
  • #11176: Fix a false positive cases for Lint/DuplicateMethods when using duplicate nested method. ([@​koic][])
  • #11164: Suppress "RuboCop server starting..." message with --server --format json. ([@​koic][])
  • #11156: Fix Style/OperatorMethodCall autocorrection when operators are chained. ([@​gsamokovarov][])
  • #11139: Fix a false negative for Style/HashEachMethods when using each with a symbol proc argument. ([@​ydah][])
  • #11161: Fix a false positive for Style/HashAsLastArrayItem when using double splat operator. ([@​koic][])
  • #11151: Fix a false positive for Lint/SuppressedException. ([@​akihikodaki][])
  • #11123: Fix autocorrection bug for Style/StringLiterals when using multiple escape characters. ([@​si-lens][])
  • #11165: Fix a false positive for Style/RedundantEach when any method is used between methods containing each in the method name. ([@​koic][])
  • #11177: Fix a false positive for Style/ObjectThen cop with TargetRubyVersion < 2.6. ([@​epaew][])
  • #11173: Fix an incorrect autocorrect for Style/CollectionCompact when using reject with block pass arg and no parentheses. ([@​koic][])
  • #11137: Fix a false positive for Style/RedundantEach when using a symbol proc argument. ([@​ydah][])
  • #11142: Fix Style/RedundantEach for non-chained each_ calls. ([@​fatkodima][])

Changes

1.38.0 (2022-11-01)

New features

Bug fixes

  • #11125: Fix an error for Layout/SpaceInsideHashLiteralBraces when using method argument that both key and value are hash literals. ([@​koic][])
  • #11132: Fix clobbering error on Lint/EmptyConditionalBody. ([@​r7kamura][])
  • #11117: Fix a false positive for Style/BlockDelimiters when specifying EnforcedStyle: semantic and using a single line block with {} followed by a safe navigation method call. ([@​koic][])
  • #11120: Fix an incorrect autocorrect for Lint/RedundantRequireStatement when using redundant require with modifier form. ([@​koic][])

Changes

  • #11131: Check newline in empty reference bracket on Layout/SpaceInsideReferenceBrackets. ([@​r7kamura][])

... (truncated)

Commits
  • 6bdf42b Cut 1.39
  • a0ecf1b Update Changelog
  • d6345ac Merge pull request #11177 from epaew/bugfix/style/object_then
  • b13c21a Fix a false positive for Style/ObjectThen cop with TargetRubyVersion < 2.6
  • 3f3c829 Fix a false positive for Lint/DuplicateMethods
  • 31720ce [Fix #11150] Improve redundant_regex_escape.rb
  • 57e7c45 Merge pull request #11144 from si-lens/fix_auto_correction_bug_for_Style/Stri...
  • 45da59a [Fix #11123 ] Fix auto correction bug for Style/StringLiterals
  • 7b265aa [Fix #11173] Fix an incorrect autocorrect for Style/CollectionCompact
  • dfb1ca5 Add autocorrect for Layout/LineContinuationLeadingSpace
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.38.0...v1.39.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 14, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 90.86% // Head: 90.86% // No change to project coverage 👍

Coverage data is based on head (ea772ce) compared to base (f3d5037).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files           8        8           
  Lines         580      580           
=======================================
  Hits          527      527           
  Misses         53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avdv avdv merged commit 574a055 into main Nov 15, 2022
@avdv avdv deleted the dependabot/bundler/rubocop-tw-1.39.0 branch November 15, 2022 21:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants