Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When the argument is a file with path provided, show the relative path of the file #594

Merged
merged 7 commits into from
May 19, 2023

Conversation

ayushpoddar
Copy link
Contributor

@ayushpoddar ayushpoddar commented Apr 29, 2023

Description

In order to demonstrate what this PR does, I am displaying the difference in the output of the command colorls exe/colorls (which is a file) before and after this PR

Before this PR

image

After this PR

image

Comment

This PR takes this gem one step closer to the behaviour of the in-built ls command.

Details

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (d1e28ed) 92.04% compared to head (414820b) 92.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   92.04%   92.13%   +0.08%     
==========================================
  Files           8        8              
  Lines         616      623       +7     
==========================================
+ Hits          567      574       +7     
  Misses         49       49              
Impacted Files Coverage Δ
lib/colorls/fileinfo.rb 90.19% <100.00%> (+1.55%) ⬆️
lib/colorls/flags.rb 89.59% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ayushpoddar ayushpoddar marked this pull request as ready for review April 29, 2023 21:21
Copy link
Collaborator

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but no need to bump the version.

@@ -1,5 +1,5 @@
# frozen_string_literal: true

module ColorLS
VERSION = '1.5.0'
VERSION = '1.5.1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't release version 1.5.0 yet, so no need to bump the version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avdv Do you need help in fixing the release script? By not releasing these latest changes, we are robbing people of all the new features being created

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but I already created a PR which fixes the problem. But I cannot merge it without an approval from another maintainer.

@@ -11,6 +11,40 @@
raise "colorls exited with #{e.status}" unless e.success?
end

let(:a_txt_file_info) do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

This reverts commit 414820b.
@ayushpoddar ayushpoddar requested a review from avdv May 12, 2023 14:16
@avdv avdv merged commit 28c188b into athityakumar:main May 19, 2023
@avdv
Copy link
Collaborator

avdv commented May 19, 2023

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants