Skip to content

Jira ServiceDesk: Fix create attachment #1121

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

skropf
Copy link
Contributor

@skropf skropf commented Feb 15, 2023

In service_desk.py/attach_temporary_file a check was added to successfully post the request. fixes #1056

If advanced mode is set the raw response must be converted to json, not so in normal mode.

Simon Kropf added 3 commits February 15, 2023 10:33
In service_desk.py/attach_temporary_file a check was added
to successfully post the request.
@codecov-commenter
Copy link

Codecov Report

Base: 35.94% // Head: 35.93% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (c4fe53f) compared to base (dc06d58).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1121      +/-   ##
==========================================
- Coverage   35.94%   35.93%   -0.02%     
==========================================
  Files          39       39              
  Lines        7163     7165       +2     
  Branches     1032     1033       +1     
==========================================
  Hits         2575     2575              
- Misses       4478     4480       +2     
  Partials      110      110              
Impacted Files Coverage Δ
atlassian/service_desk.py 38.70% <0.00%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gonchik gonchik merged commit 1379a2e into atlassian-api:master Feb 16, 2023
@gonchik
Copy link
Member

gonchik commented Feb 16, 2023

@skropf Thank you!

@skropf skropf deleted the bugfix/attach_temporary_file branch February 16, 2023 10:46
@JudithBabbel
Copy link

nice report.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Service Desk] Creating/Adding attachments
4 participants