Skip to content

Bug/fix assign issue #728

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Sep 17, 2022
Merged

Conversation

kkjorsvik
Copy link
Contributor

#515 (comment)
The above issue points out the assign_issue using username has been deprecated and now requires the accountId instead. I have updated the code to use accountId.

Copy link
Contributor

@dephekt dephekt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assignee parameter should probably be changed to reflect the name of the new parameter. E.g. change the input parameter from assignee to account_id to match the style of other methods using an accountId parameter.

It's a little confusing when the Python method parameter doesn't match the REST API parameter. E.g. this probably should have been called name rather than assignee originally, so now is a good time to fix that too, IMHO.

While you're at it, it's probably a good time to update the docs/jira.rst to document the usage of the method? It's currently undocumented but it's a commonly used method.

@kkjorsvik
Copy link
Contributor Author

Thank you, and I agree with you that those are good changes that should be apart of this pull request. I will work on cleaning things up a bit more. Should I change this Pull Request to a draft or will it be ok to leave it open?

@dephekt
Copy link
Contributor

dephekt commented Feb 25, 2021

Good question. It's probably OK to leave it open but I personally keep mine as drafts until I'm ready for it to be potentially merged, just to avoid any accidents. Then when I think it's ready, I switch it back.

@kkjorsvik kkjorsvik marked this pull request as draft February 25, 2021 04:58
@Spacetown Spacetown mentioned this pull request Jul 17, 2021
@gonchik gonchik marked this pull request as ready for review September 17, 2022 09:44
@gonchik gonchik merged commit abc692a into atlassian-api:master Sep 17, 2022
@kkjorsvik kkjorsvik deleted the bug/fix-assign-issue branch August 16, 2023 17:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants