Make access log pattern configurable for Jira and Confluence #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanux
reviewed
Feb 17, 2025
| @@ -191,6 +191,7 @@ see <https://tomcat.apache.org/tomcat-7.0-doc/config/index.html>. | |||
| You can set the maximum number of days for access logs to be retained before being deleted. The default value of -1 means never delete old files. | |||
|
|
|||
| * `ATL_TOMCAT_ACCESS_LOGS_MAXDAYS` (default: -1) | |||
| * `ATL_TOMCAT_ACCESS_LOG_PATTERN` (default: `%h %{X-AUSERNAME}o %t "%r" %s %b %D %U %I "%{User-Agent}i"`) | |||
There was a problem hiding this comment.
Where are the types/placeholders defined? Is that standard from tomcat? Can we link some docs?
There was a problem hiding this comment.
https://confluence.atlassian.com/doc/configure-access-logs-1044780567.html
https://confluence.atlassian.com/adminjiraserver/log-format-940696477.html
we just keep using whatever default/hardcoded value we had in Jinja template.
nanux
approved these changes
Feb 17, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it configurable when server.xml is generated by Helm in a ConfigMap.
Checklist
e2elabel)