Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nucleus does not handle delta publish artifacts from electron-forge #89

Open
b-zurg opened this issue May 11, 2020 · 6 comments
Open

Nucleus does not handle delta publish artifacts from electron-forge #89

b-zurg opened this issue May 11, 2020 · 6 comments

Comments

@b-zurg
Copy link

b-zurg commented May 11, 2020

I'm trying to configure electron-forge to upload artifacts to nucleus as it seems like a great solution, however every time I try to release a set of release artifacts I encounter a problem.

The delta updates are being built and uploaded fine but when releasing the following output is shown:

nucleus_1  | Mon, 11 May 2020 08:09:10 GMT nucleus:rest TypeError: Cannot read property 'toUpperCase' of null
nucleus_1  |     at Object.<anonymous> (/opt/service/lib/files/utils/win32.js:25:44)
nucleus_1  |     at Generator.next (<anonymous>)
nucleus_1  |     at fulfilled (/opt/service/lib/files/utils/win32.js:4:58)
nucleus_1  |     at <anonymous>
nucleus_1  | Mon, 11 May 2020 08:09:10 GMT nucleus:rest Fetching temporary releases for app: brl and channel: Stable
nucleus_1  | Mon, 11 May 2020 08:09:10 GMT nucleus:rest Listing applications

The property that it's talking about is the sha1 property. I desperately want to use nucleus but if delta updates are not working then that's a hard pill to swallow.

Interestingly enough updates are all good when not doing delta updates and just uploading 2 full packages.

@psamim
Copy link

psamim commented Sep 21, 2020

Too sad.

@b-zurg
Copy link
Author

b-zurg commented Sep 22, 2020

Too sad.

Are you experiencing the same thing?

@psamim
Copy link

psamim commented Sep 23, 2020

@b-zurg Yes.

@b-zurg
Copy link
Author

b-zurg commented Sep 24, 2020

I think nucleus is pretty viable if you can stomach not having Delta updates. Otherwise the differential updates that electron-builder has works pretty well as and is even more efficient than squirrel's delta updates.

@psamim
Copy link

psamim commented Sep 24, 2020

@b-zurg Dear Buzurg! I tried to setup publishing with electron-builder but failed, as I was confused by the its docs but forge and nucleus combination was so straight forward and easy. Are you referring to the nsis format? Also I would really appreciate it if you could point me to an example repo or something.

@TomaterID
Copy link

Guys, I nailed down this problem in the code with this, and few others too. Working on patch right now. Unfortunately, there is no point to push PR for that, as no one is reviewing them. If someone interested - fixes will be in my fork of the repo. I also think about doing some UI improvements too. Currently it is not very convenient.

TomaterID added a commit to TomaterID/nucleus that referenced this issue Oct 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants