Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Commit pane item #1655

Closed
smashwilson opened this issue Aug 20, 2018 · 2 comments
Closed

Commit pane item #1655

smashwilson opened this issue Aug 20, 2018 · 2 comments
Labels

Comments

@smashwilson
Copy link
Contributor

Let's design a pane item to show the contents of a single commit. 🎨 The work in #1512 will allow us to show much larger diffs in a performant way, which opens the door to a full-commit view.

We can access it by:

  • Clicking on an entry in the recent commits view
  • (Maybe) showing the combined staged changes while the keyboard focus is in the commit message editor, like a git commit -v
  • (Eventually) clicking on a commit entry in the issueish pane item
  • (Eventually) from diving into a single commit on the log view (RFC for Interactive Log View #1419)

We'll want to show the full diff with some kind of navigation controls to allow you to move among the changed files. It'd also be a good place to put controls for contextual actions that you can take on that commit: amending the most recent, hard and soft resets, revert, checkout, create and checkout a new branch.

@simurai
Copy link
Contributor

simurai commented Sep 10, 2018

We'll want to show the full diff with some kind of navigation controls to allow you to move among the changed files.

Does this mean that in the same pane, there are diffs of multiple files stacked on top of each other, like on .com and the navigation controls would change the scroll position? That would be nice for allowing:

(Maybe) showing the combined staged changes while the keyboard focus is in the commit message editor

Like when there are 2 changed files you don't have to switch between them and could just scroll and see the diff of both files.

@simurai
Copy link
Contributor

simurai commented Oct 26, 2018

Mockups for:

(Maybe) showing the combined staged changes while the keyboard focus is in the commit message editor, like a git commit -v

commit-preview

In the mockup, there is a "Preview" button that can be clicked to see a preview of the next commit... showing it on focus would be handy in a lot of cases, but it could also be annoying if you were looking at something to help write your commit message?

If you click the "Preview" button, but there is no commit message, it just shows ....

image

Clicking on an entry in the recent commits view

commit-pane

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants