Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: memcheck with tests #486

Merged
merged 3 commits into from
Jan 3, 2025
Merged

feat: memcheck with tests #486

merged 3 commits into from
Jan 3, 2025

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Dec 23, 2024

- What I did

  • Added a Dockerfile to build a memcheck environment that can be run locally
    • Neither valgrind or valgrind-macos are supported on apple silicon, hence the need for docker
  • Added three main just commands:
    • just memcheck
      • run memcheck without the docker container, suitable for machines which are configured to run ctest memcheck
    • just setup-memcheck-docker
      • calls docker build with the appropriate arguments
    • just memcheck-docker or just memd (alias)
      • Runs the ctest -T memcheck ... in a temporary docker container
      • The build & test logs are cached on disk, meaning re-runs don't require a full rebuild
  • There are some discovered leaks which need to be resolved before we add this to CI

- How I did it

- How to verify it

Local run:
https://gist.github.com/XavierChanth/7051e076e9e03cdf1444c6484c69a386

- Description for the changelog
feat: memcheck with tests

@XavierChanth XavierChanth force-pushed the memcheck branch 3 times, most recently from d713b41 to 3b86774 Compare January 3, 2025 00:51
@XavierChanth XavierChanth changed the title [WIP] feat: memcheck with tests feat: memcheck with tests Jan 3, 2025
@XavierChanth XavierChanth marked this pull request as ready for review January 3, 2025 01:14
@XavierChanth XavierChanth merged commit 0192eb7 into trunk Jan 3, 2025
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants