Input file: support reading from stdin, symlinks, others #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not support reading a directory as an input file, since there's no exclusive file extension or an easy way to detect test files among other files. Alternatively, users can inform a glob, for example `dir/*.sh`.
At the end, it doesn't matter if it is a normal file or not, what matters is that we can read the tests from "somewhere". Relaxing this check now allows for reading tests from different kinds of files, such as symlinks and special devices such as `/dev/stdin`.
Using `-` to mean that the file comes from from STDIN is a Unix classic.
Let's support it.
The implementation is not that clean, in the sense that the "fake"
temporary path will appear when using two or more input files, and one
of them is `-`. But in the summary table at the end it correctly shows
`-`. Example:
$ cat x
$ echo 1
2
$
$ cat x | ./clitest - x
Testing file /var/folders/zj/1vb37fxj2rd2glwn48nrsjl80000gq/T//clitest.zfwux7/stdin.txt
#1 echo 1
-------------------------------------------------
[FAILED #1, line 1] echo 1
@@ -1 +1 @@
-2
+1
-------------------------------------------------
Testing file x
#2 echo 1
-------------------------------------------------
[FAILED #2, line 1] echo 1
@@ -1 +1 @@
-2
+1
-------------------------------------------------
ok fail skip
- 1 - -
- 1 - x
FAIL: 2 of 2 tests failed
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, clitest only accepted the input file if it was a "normal"
(as in
test -f) file. But that's too restrictive, for no reason. Atthe end, it doesn't matter if it is a normal or a special file, what
matters is that it is readable and we can find the tests on it.
With those changes, now the input file can be:
/dev/stdinin systems that support it-as a shortcut to stdinReading from directories continues to be forbidden (we can't properly
identify clitest input files), but at least now the error message is
more clear that it is a directory.
Issue #32