Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove ad hoc constant from unit slot example. #371

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

hoffbrinkle
Copy link
Contributor

When demonstrating that we can pass Constant to a unit slot, use the available
builtin constant for the speed of light rather than creating an ad hoc
constant.

When demonstrating that we can pass `Constant` to a unit slot, use the available
builtin constant for the speed of light rather than creating an ad hoc
constant.
Copy link
Contributor

@geoffviola geoffviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. This example is more readable and copyable. The changes match the suggestion made out of band.

@chiphogg chiphogg merged commit 3fd12f8 into main Jan 1, 2025
14 checks passed
@chiphogg chiphogg deleted the hoffbrinkle/unit_slot_example branch January 1, 2025 20:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants