Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enforce uber-es2015 Coding Style (PR#1 of 2) #38

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Enforce uber-es2015 Coding Style (PR#1 of 2) #38

merged 2 commits into from
Sep 6, 2018

Conversation

ibgreen
Copy link
Contributor

@ibgreen ibgreen commented Sep 5, 2018

For #37

Changes

  • Remove .eslintrc overrides (mainly camelcase)
  • fix linter setup (lint right folders, make script work independently)
  • update source code to pass linter and prettier under new rules

@ibgreen ibgreen merged commit 88d29a9 into master Sep 6, 2018
@ibgreen ibgreen deleted the ib/uber-es2015 branch September 6, 2018 14:45
ibgreen pushed a commit that referenced this pull request Sep 6, 2018
Initial round of uber-es2015 coding style changes (#38)
e802edc
twojtasz pushed a commit that referenced this pull request Jan 23, 2019
Initial round of uber-es2015 coding style changes (#38)
59d6e69
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@twojtasz twojtasz twojtasz approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

@xintongxia xintongxia Awaiting requested review from xintongxia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibgreen @twojtasz