Update callback verification in HttpRequest. #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot a method of $mockedResponse Changed the method_exists check to a property_exists check in the HttpRequest class. This adjustment ensures that 'callback' is an accessible property of the object before attempting to invoke it. This change improves code reliability, specifically for the cases where HttpRequest is used in unit tests with mock responses.
A new test case 'the callback of a mock response is called' was added to further ensure the robustness of the application.
evansims
approved these changes
Jul 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
'callback' is a property not a method of $mockedResponse
Changed the method_exists check to a property_exists check in the HttpRequest class. This adjustment ensures that 'callback' is an accessible property of the object before attempting to invoke it. This change improves code reliability, specifically for the cases where HttpRequest is used in unit tests with mock responses.
References
#768 Callback Never Called
Testing
A test has been added to assert the fix is working as expected
Contributor Checklist