Add Revoke Refresh Token endpoint #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
previously approved these changes
Nov 26, 2018
| been issued for the same user, application, and audience will be revoked. | ||
|
|
||
| Args: | ||
| client_id (str): your application's client Id |
There was a problem hiding this comment.
Consider:
The Client ID for your Application
| Args: | ||
| client_id (str): your application's client Id | ||
|
|
||
| token (str): the Refresh Token you want to revoke |
|
|
||
| token (str): the Refresh Token you want to revoke | ||
|
|
||
| client_secret (str, optional): Your application's Client Secret. |
There was a problem hiding this comment.
Consider:
The Client Secret for your Application
| token (str): the Refresh Token you want to revoke | ||
|
|
||
| client_secret (str, optional): Your application's Client Secret. | ||
| Required for confidential applications. |
There was a problem hiding this comment.
This is confusing ... what is a "confidential application?" This doesn't tell me much about when I should be using this.
There was a problem hiding this comment.
It's explained like that in the api explorer linked. I'll add a more explicit link
joshcanhelp
approved these changes
Nov 27, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115