empty expected audience array should throw InvalidClaimException #679
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor aud claim logic to make it more readable and easier to update. No functional changes.
poovamraj
approved these changes
Nov 30, 2023
This was referenced Jan 22, 2025
Merged
Merged
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, validating a JWT expecting an empty string array fails with a NPE, instead of an
InvalidClaimException, as discussed in #674. This change fixes that.It also includes a small refactor to the audience validation logic, replacing the terse conditional with clearer and more extendable logic. That change was done in a commit prior to making any logic changes to ensure no unintended changes.
Fixes #674.