-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ensure build is run on prepack #167
Conversation
3f32c52
to
c36d046
Compare
Force merging this to fix the broken beta release. |
Any particular reason why |
It does, we use npm publish (see: https://github.com/auth0/jwt-decode/blob/beta/.circleci/config.yml#L39), and prepack solved it (it's what's we use on all SDKs, no particular reason). See https://docs.npmjs.com/cli/v9/using-npm/scripts#life-cycle-operation-order |
The main benefit is it also runs on npm pack, which we use to try the tarball locally, so just a little bit of convenience over prePublishOnly |
The page mentions that |
I'd still expect it to run either way, even if I omit |
Description
Ensure to build before running
npm pack
ornpm publish
.References
See: #151 (comment)
Checklist