Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Configurable Route Paths #436

Merged
merged 17 commits into from
Dec 9, 2023
Merged

Conversation

evansims
Copy link
Member

@evansims evansims commented Dec 7, 2023

Changes

This PR restores previous SDK behavior in allowing the configuration of route paths.

References

Resolves #432

Testing

Tests have been updated to cover the changes. Coverage remains at 100%.

Contributor Checklist

@evansims evansims added the Scope: Improvement Proposed improvements, or feature additions. label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4482d34) 100.00% compared to head (6a490fe) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #436   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       530       532    +2     
===========================================
  Files             31        31           
  Lines           1309      1325   +16     
===========================================
+ Hits            1309      1325   +16     
Flag Coverage Δ
unittestsvalidate 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims marked this pull request as ready for review December 8, 2023 17:49
@evansims evansims requested a review from a team as a code owner December 8, 2023 17:49
@evansims evansims disabled auto-merge December 9, 2023 01:44
@evansims evansims merged commit ac12090 into main Dec 9, 2023
@evansims evansims deleted the feat/restore-configurable-route-paths branch December 9, 2023 01:45
@evansims evansims mentioned this pull request Dec 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Scope: Improvement Proposed improvements, or feature additions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore 7.6 feature of configurable login route
1 participant