Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate Request lib #475

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

davidpatrick
Copy link
Contributor

Changes

  • Replaced request library with axios
  • Added form-data library to handle form posting with axios
  • Removed no longer needed utility getRequestPromise
  • Updated jwks-rsa to 1.8.0

References

Closes #464

Testing

Validated request and error handling with axios.

@davidpatrick davidpatrick requested a review from a team April 14, 2020 05:47
@adamjmcgrath adamjmcgrath self-assigned this Apr 14, 2020
test/auth/tokens-manager.tests.js Outdated Show resolved Hide resolved
@davidpatrick davidpatrick merged commit 32f0001 into auth0:master Apr 14, 2020
@davidpatrick davidpatrick deleted the deprecate-request branch April 14, 2020 21:29
@davidpatrick davidpatrick added this to the v2.25.0 milestone Apr 15, 2020
@davidpatrick davidpatrick mentioned this pull request Apr 15, 2020
@davidpatrick davidpatrick mentioned this pull request Apr 29, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request lib is deprecated
2 participants