Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix deprecation warning in importUserJobs #537

Conversation

JCQuintas
Copy link
Contributor

Changes

The importUsers deprecation warning shows up even when using the suggested importUsersJob, this MR fixes that by moving importUsers logic into _importUsers. Then only when the deprecated function is called we display the warning.

References

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • management.jobs.importUsersJob should not display a warning
  • management.jobs.importUsers should display a warning
  • Existing tests still run

Checklist

@JCQuintas JCQuintas requested a review from a team September 25, 2020 22:07
@frederikprijck
Copy link
Member

Thanks for the PR @JCQuintas , that's a nice catch, very much appreciated!

@frederikprijck frederikprijck requested review from Adam-Auth0 and davidpatrick and removed request for davidpatrick and Adam-Auth0 October 7, 2020 07:01
@frederikprijck frederikprijck merged commit c509610 into auth0:master Oct 7, 2020
@JCQuintas JCQuintas deleted the fix-deprecation-warning-in-import-user-job branch October 7, 2020 09:53
@frederikprijck frederikprijck added this to the v2.30.0 milestone Dec 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants