Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add DELETE /api/v2/users/{id}/authenticators #785

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Feb 9, 2023

Changes

fixes #782

References

https://auth0.com/docs/api/management/v2#!/Users/delete_authenticators
auth0/auth0-python#301

Testing

  • This change adds unit test coverage

Checklist

@adamjmcgrath adamjmcgrath added the review:small Small review label Feb 9, 2023
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner February 9, 2023 10:31
src/management/UsersManager.js Outdated Show resolved Hide resolved
@adamjmcgrath adamjmcgrath merged commit 8a63cf9 into master Feb 9, 2023
@adamjmcgrath adamjmcgrath deleted the user-del-all-auths branch February 9, 2023 11:22
@adamjmcgrath adamjmcgrath mentioned this pull request Feb 9, 2023
@flpelluz
Copy link

Hi @adamjmcgrath @frederikprijck, do you happen to know when the definition will be added to https://github.com/auth0/node-auth0/blob/master/src/management/index.js so that we can use it via the client? Thanks!

@frederikprijck
Copy link
Member

frederikprijck commented Feb 17, 2023

Hey @flpelluz ,

The users manager is exposed on the client through the users property, afaik that's the go-to approach rather than exposing all methods seperatly on the client like done before.

See https://github.com/auth0/node-auth0/blob/master/src/management/index.js#L210

Let me know if that wouldnt work.

@flpelluz
Copy link

Hi @frederikprijck, thanks for the quick reply!

I didn't know that was the new approach, yet, I noticed it was exposed on the users property. In fact, I tried reaching the function via the property but for some reason I got an error. I didn't dive much into the code and thought that perhaps exposing it might be missing. Anyway, I just tried now again and it worked nicely, so I guess it's just a rough Friday on my end 😅

Cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ManagementClient] Delete All User Authenticators
3 participants