Remove Social Amplificator functionality #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
============================================
+ Coverage 34.34% 36.01% +1.67%
+ Complexity 1314 1270 -44
============================================
Files 54 52 -2
Lines 4161 3968 -193
============================================
Hits 1429 1429
+ Misses 2732 2539 -193
Continue to review full report at Codecov.
|
lbalmaceda
reviewed
Jan 2, 2019
lib/WP_Auth0_Api_Client.php
Outdated
| @@ -305,6 +305,7 @@ public static function create_client( $domain, $app_token, $name ) { | |||
|
|
|||
| 'callbacks' => array( | |||
| $options->get_wp_auth0_url(), | |||
| $options->get_wp_auth0_url(), | |||
There was a problem hiding this comment.
why does this array contains the same url twice?
There was a problem hiding this comment.
Odd ... that should not be a part of this PR. I'll remove it.
lbalmaceda
approved these changes
Jan 2, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes the Social Amplificator functionality and adds notes to formally deprecate classes.
This does not introduce any breaking changes, just removes the widgets and options from the admin screens.