Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Validate composer config #788

Merged
merged 3 commits into from
Apr 6, 2020
Merged

Validate composer config #788

merged 3 commits into from
Apr 6, 2020

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Apr 6, 2020

Shocked 😲 me in #787

Closes #787

@szepeviktor szepeviktor requested a review from a team April 6, 2020 17:04
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szepeviktor - Good find! Can you also add this command to the pre-commit Composer script so it's hopefully caught before being pushed?

@szepeviktor
Copy link
Contributor Author

Done.
See https://getcomposer.org/doc/articles/scripts.md#calling-composer-commands

Co-Authored-By: Josh Cunningham <josh@joshcanhelp.com>
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing master:

❯ composer pre-commit 
./composer.json is valid
> "vendor/bin/phpcs"
............................................................ 60 / 66 (91%)
......                                                       66 / 66 (100%)


Time: 13.3 secs; Memory: 22MB

> "vendor/bin/phpunit"
Installing...
Running as single site... To run multisite, use -c tests/phpunit/multisite.xml
Not running ajax tests. To execute these, use --group ajax.
Not running ms-files tests. To execute these, use --group ms-files.
Not running external-http tests. To execute these, use --group external-http.
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.1.33 with Xdebug 2.6.1
Configuration: /Users/josh-cunningham/Sites/wp-auth0/wp-content/plugins/auth0/phpunit.xml.dist

...............................................................  63 / 409 ( 15%)
............................................................... 126 / 409 ( 30%)
............................................................... 189 / 409 ( 46%)
............................................................... 252 / 409 ( 61%)
............................................................... 315 / 409 ( 77%)
............................................................... 378 / 409 ( 92%)
...............................                                 409 / 409 (100%)

Time: 17.49 seconds, Memory: 48.00MB

OK (409 tests, 1561 assertions)

@joshcanhelp joshcanhelp merged commit 709ec49 into auth0:master Apr 6, 2020
@szepeviktor szepeviktor deleted the patch-1 branch April 6, 2020 18:14
@szepeviktor
Copy link
Contributor Author

Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants