Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate Social Amplificator classes + methods #612

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jan 2, 2019

Changes

Officially deprecating methods/classes for the Social Amplificator feature.

References

Removed in #607

@@ -520,97 +520,6 @@ public function render_custom_#_fields( $args = array() ) {
);
}

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality unchanged, moved to the deprecated section of the file.

@joshcanhelp joshcanhelp added this to the 3.9.0 milestone Jan 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #612 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #612      +/-   ##
============================================
+ Coverage     36.01%   36.29%   +0.28%     
+ Complexity     1270     1266       -4     
============================================
  Files            52       52              
  Lines          3968     3937      -31     
============================================
  Hits           1429     1429              
+ Misses         2539     2508      -31
Impacted Files Coverage Δ Complexity Δ
WP_Auth0.php 22.45% <ø> (ø) 62 <0> (ø) ⬇️
lib/admin/WP_Auth0_Admin_Advanced.php 30.55% <ø> (+2.96%) 60 <0> (-4) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da69a55...be0c56a. Read the comment docs.

@joshcanhelp joshcanhelp merged commit 57847bb into master Jan 3, 2019
@joshcanhelp joshcanhelp deleted the deprecate-amplificator branch January 8, 2019 16:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants