Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to build with .NET 8, update dependencies #46

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Conversation

tillig
Copy link
Member

@tillig tillig commented Jul 12, 2024

  • Updates Autofac core dependency to 8.0.0, which includes a breaking Autofac core change so the configuration library increments to 7.0.0 major release. This also includes some differences in how constructor discovery is done (public vs. internal) so changes here were made to consistently throw constructor-not-found-exceptions as needed.
  • Update all other internal dependencies including MS configuration. This changes some minor behaviors since .NET 2 - including changing handling of empty objects/lists in configuration.
  • Update build to use .NET 8 SDK, but still target netstandard2.0 and netstandard2.1.
  • Fixes to nullable annotations.
  • Switch embedded resources to build in the new VS Code compatible way.
  • Standardize on US English for some spellings.
  • Added tests to improve overall coverage.

@tillig tillig requested a review from alistairjevans July 12, 2024 19:26
@tillig
Copy link
Member Author

tillig commented Jul 12, 2024

When this is merged I'll release a full major update and it will include the fix for #44 from @pnagoorkar.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.74%. Comparing base (ecfb304) to head (59dbc8c).

Files Patch % Lines
...c/Autofac.Configuration/Core/ComponentRegistrar.cs 75.00% 2 Missing ⚠️
src/Autofac.Configuration/Util/StringExtensions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    65.54%   73.74%   +8.19%     
===========================================
  Files           11       10       -1     
  Lines          386      358      -28     
  Branches       119      117       -2     
===========================================
+ Hits           253      264      +11     
+ Misses          70       42      -28     
+ Partials        63       52      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🐧

@tillig tillig merged commit 4fff3f5 into develop Jul 13, 2024
6 checks passed
@tillig tillig deleted the feature/net8 branch July 13, 2024 20:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants