Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add generic overloads for TryResolveNamed and TryResolveKeyed #1287

Merged

Conversation

v0idzz
Copy link
Contributor

@v0idzz v0idzz commented Aug 29, 2021

This adds generic counterparts for TryResolveNamed and TryResolveKeyed extensions.

Closes #1263

@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #1287 (420b70b) into develop (6c6c7c0) will decrease coverage by 0.05%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1287      +/-   ##
===========================================
- Coverage    76.64%   76.58%   -0.06%     
===========================================
  Files          188      188              
  Lines         5163     5177      +14     
  Branches      1057     1061       +4     
===========================================
+ Hits          3957     3965       +8     
- Misses         708      711       +3     
- Partials       498      501       +3     
Impacted Files Coverage Δ
src/Autofac/ResolutionExtensions.cs 51.14% <71.42%> (+2.42%) ⬆️
src/Autofac/Util/AsyncReleaseAction.cs 71.42% <0.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c6c7c0...420b70b. Read the comment docs.

Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@alistairjevans alistairjevans merged commit 4c5d3ab into autofac:develop Aug 29, 2021
@v0idzz v0idzz deleted the feature/generic-resolution-overloads branch August 29, 2021 18:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generic counterparts for TryResolveNamed, TryResolveKeyed and TryResolveService
2 participants