Update multimodal dep #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzhoum
force-pushed
the
update_multimodal_dep
branch
from
72062c2 to
84435bf
Compare
| @@ -606,11 +593,9 @@ class JCPennyCategory(BaseMultiModalDataset): | |||
| _INFO = { | |||
| "train": { | |||
| "url": get_repo_url() + "jc_penney_products/train.csv", | |||
There was a problem hiding this comment.
Why did we need SHA's earlier?
and why do we remove it?
There was a problem hiding this comment.
SHA is not a required field and was in place for sanity check. Since we might have to update datasets sometimes, it is required to update the sha as well which is too much hassle.
suzhoum
force-pushed
the
update_multimodal_dep
branch
from
faf0b3d to
5078838
Compare
suzhoum
force-pushed
the
update_multimodal_dep
branch
from
5078838 to
ac03ae8
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
mmcvandmmdetversionresultcolumn for the primary metrics inresults.csvpredictor.fit(time_limit)withTIME_LIMITdefined forcdk_contextBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.