Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use TaskGroup to wait on network activating or retry timeout, whichever is first #102

Merged
merged 6 commits into from
May 20, 2024

Conversation

jessegrosjean
Copy link
Contributor

I think this addresses #87

@jessegrosjean
Copy link
Contributor Author

@heckj Also, if you have any idea how to get rid of the for try await _ in group (and see commented code above) let me know. I haven't done much work with async and can't see why one works without warning and the other doesn't.

Copy link
Collaborator

@heckj heckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only reading on an iPad and commenting based on knowledge with this so far - I want to experiment with some variations on the branch tomorrow when I'm more cogent to see if I can get your original desired setup - intentionally racing the two tasks - sorted, as I think that's a lot easier to understand.

@heckj
Copy link
Collaborator

heckj commented May 20, 2024

failing test appears to be a flake. I'm going to briefly hold merging this to lock down where that flake is happening, then merge this (assuming it is unrelated, which i'll check as i dig it out when I get home)

@heckj heckj merged commit c24502c into automerge:main May 20, 2024
1 check failed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants