Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

turn am into a full workspace #147

Merged
merged 1 commit into from
Oct 10, 2023
Merged

turn am into a full workspace #147

merged 1 commit into from
Oct 10, 2023

Conversation

mellowagain
Copy link
Member

@mellowagain mellowagain commented Oct 6, 2023

the cargo workspace now has three members:

  • am: the actual cli binary
  • autometrics-am: the accompanying library of am
  • am_list: self explanatory

im kinda not that happy with the naming right now, maybe we should rename the library to something which makes more sense than autometrics-am? i can imagine contributors might get confused about what it is compared to am. im open for ideas, i thought about smth like libam

fixes #129

Checklist

  • Changelog updated

@mellowagain mellowagain requested a review from a team as a code owner October 6, 2023 08:07
Copy link
Contributor

@hatchan hatchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can tweak the naming later. Will this PR have any impact on the work that @gagbo is doing?

@mellowagain mellowagain merged commit 6e512cf into main Oct 10, 2023
@mellowagain mellowagain deleted the workspace branch October 10, 2023 09:55
@gagbo
Copy link
Member

gagbo commented Oct 10, 2023

It should be fine with things. That mostly reminds me that the GitHub action needs to be updated.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a workspace for am
3 participants