Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expose metrics and other improvements #77

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Expose metrics and other improvements #77

merged 1 commit into from
Aug 16, 2023

Conversation

actualwitch
Copy link
Contributor

@actualwitch actualwitch commented Aug 14, 2023 •
edited
Loading

  • reexport start_http_server from prom-client, add some docs about it Automatically serve /metrics on port 9464 #69
  • add settings - all env vars are also configurable via the init function (will not detect correctly monkeypatching env though)
  • parallel test runs
  • update deps

@actualwitch actualwitch force-pushed the expose-metrics branch 22 times, most recently from 7d64a23 to 0453388 Compare August 15, 2023 10:27
flenter
flenter approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@flenter flenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice. I noticed that this PR also updates a couple of dependencies. Does it address all the open dependabot alerts?

@actualwitch actualwitch force-pushed the expose-metrics branch 2 times, most recently from e95b041 to 2a85e09 Compare August 16, 2023 14:34
@actualwitch
Copy link
Contributor Author

@flenter yes, it should resolve at least 2, idk where one of them originates 🤷‍♀️

@actualwitch actualwitch merged commit 5fdb19b into main Aug 16, 2023
@actualwitch actualwitch deleted the expose-metrics branch August 16, 2023 14:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@flenter flenter flenter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@actualwitch @flenter