Rename metrics to spec and add descriptions #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
arendjr
approved these changes
Jul 14, 2023
| export const COUNTER_NAME = "function.calls" as const; | ||
| export const HISTOGRAM_NAME = "function.calls.duration" as const; | ||
| export const GAUGE_NAME = "function.calls.concurrent" as const; | ||
| export const BUILD_INFO_NAME = "build_info" as const; |
There was a problem hiding this comment.
Like we're using constants for it 👍
| @@ -10,7 +19,6 @@ import { | |||
| isObject, | |||
| isPromise, | |||
| } from "./utils"; | |||
| import { setBuildInfo } from "./buildInfo"; | |||
There was a problem hiding this comment.
Do you use Rome's import organizer? Curious what's your experience if so :)
There was a problem hiding this comment.
This was actually tsserver's own API for organizing imports! :)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates metric names according to the latest versions of the spec and adds descriptions for them.