Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add riscv64 support #3109

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Add riscv64 support #3109

merged 2 commits into from
Oct 9, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Oct 9, 2024

Tried for fun, took just a few minutes, but then node failed to compile in CI due to briansmith/ring#2148, which resulted in:

If at least one of those two were not the case it'd work fine, but as is node fails to compile unfortunately. So it took a bit more than a few minutes overall, but still time well spend IMO as both of reported issues should be fixed regardless.

Code contributor checklist:

@nazar-pc
Copy link
Member Author

nazar-pc commented Oct 9, 2024

Also fixed container image builds in the latest commit

@nazar-pc nazar-pc enabled auto-merge October 9, 2024 14:31
@nazar-pc nazar-pc requested a review from dariolina October 9, 2024 14:32
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nazar-pc nazar-pc added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit bda8801 Oct 9, 2024
9 checks passed
@nazar-pc nazar-pc deleted the riscv64-support branch October 9, 2024 20:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants