Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Continue on error remove validator #2280

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Continue on error remove validator #2280

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8adc74
contiunue if validator removal process already started
felipemadero Oct 18, 2024
1cbc6b8
address PR comment
felipemadero Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/validatormanager/removal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@

import (
_ "embed"
"errors"
"math/big"

"github.com/ava-labs/avalanche-cli/pkg/application"
"github.com/ava-labs/avalanche-cli/pkg/contract"
"github.com/ava-labs/avalanche-cli/pkg/evm"
"github.com/ava-labs/avalanche-cli/pkg/models"
"github.com/ava-labs/avalanche-cli/pkg/ux"
"github.com/ava-labs/avalanche-cli/sdk/interchain"
"github.com/ava-labs/avalanchego/api/info"
"github.com/ava-labs/avalanchego/ids"
Expand Down Expand Up @@ -129,7 +131,10 @@
validationID,
)
if err != nil {
return nil, ids.Empty, evm.TransactionError(tx, err, "failure initializing validator removal")
if !errors.Is(err, errInvalidValidatorStatus) {
return nil, ids.Empty, evm.TransactionError(tx, err, "failure initializing validator removal")
}
ux.Logger.PrintToUser("Warning: the validator removal process was already initialized. Proceesing to the next step.")

Check failure on line 137 in pkg/validatormanager/removal.go

View workflow job for this annotation

GitHub Actions / Lint 

`Proceesing` is a misspelling of `Proceeding` (misspell)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validator removal process was already initialized. Proceeding to the next step.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for warning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, we can remove PrintToUser

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

}

aggregatorLogLevel, err := logging.ToLevel(aggregatorLogLevelStr)
Expand Down
Loading