Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include VM path in plugin version error #3178

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Adds the explicit file that should be updated to the error message.

How this works

Passes the file path into the initializer.

How this was tested

  • Manually:
[07-07|11:26:13.794] ERROR node/node.go:1287 failed to register VM {"vmID": "srEXiWaHuhNyGwPUi444Tu47ZEDwxTWrbQiuD7FmgSAQ6X7Dy", "error": "handshake failed: RPCChainVM protocol version mismatch between AvalancheGo and Virtual Machine plugin. AvalancheGo version v1.11.9 implements RPCChainVM protocol version 35. The VM located at /Users/stephen/.avalanchego/plugins/srEXiWaHuhNyGwPUi444Tu47ZEDwxTWrbQiuD7FmgSAQ6X7Dy implements RPCChainVM protocol version 33. Please make sure that there is an exact match of the protocol versions. This can be achieved by updating your VM or running an older/newer version of AvalancheGo. Please be advised that some virtual machines may not yet support the latest RPCChainVM protocol version"}

@StephenButtolph StephenButtolph added documentation Improvements or additions to documentation or examples monitoring This primarily focuses on logs, metrics, and/or tracing labels Jul 7, 2024
@StephenButtolph StephenButtolph added this to the v1.11.10 milestone Jul 7, 2024
@StephenButtolph StephenButtolph self-assigned this Jul 7, 2024
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change look good. do you mind if I'll add a unit test for this ?

@StephenButtolph
Copy link
Contributor Author

change look good. do you mind if I'll add a unit test for this ?

@tsachiherman would you want to add the unit test on top of this PR? Or in this PR itself? I'm all for adding more tests.

@tsachiherman
Copy link
Contributor

change look good. do you mind if I'll add a unit test for this ?

@tsachiherman would you want to add the unit test on top of this PR? Or in this PR itself? I'm all for adding more tests.

this PR looks ready.. I'll do it in a separate PR based on this one. ( that way, you could merge this one right away )

@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 11, 2024
Merged via the queue into master with commit 4e0a7c3 Jul 11, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the include-vm-path branch July 11, 2024 11:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation or examples monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants