[e2e] Abstract usage of ginkgo with a new test context #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
e2e-test-context
branch
3 times, most recently
from
9f301eb to
99294e5
Compare
Comment on lines
+22
to
+24
| func NewTestContext() *GinkgoTestContext { | ||
| return &GinkgoTestContext{} | ||
| } |
There was a problem hiding this comment.
Why not embed ginkgo.GinkgoT() and possibly require.New(t) here to cut out some of the wrapper code?
There was a problem hiding this comment.
What do you mean by embed? The TestContext interface does embed require.TestingT. Or are you thinking the context type should have a method to return a require instance?
aaronbuchwald
approved these changes
Jul 31, 2024
|
Rebased |
1 task
StephenButtolph
approved these changes
Aug 2, 2024
marun
added a commit
that referenced
this pull request
Aug 8, 2024
marun
added a commit
that referenced
this pull request
Aug 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Reuse of e2e tests and tooling requires removing direct dependency on ginkgo. This PR adds a new TestContext type that must be explicitly used to access the global ginkgo functions. This enables reuse of tmpnet glue code for #3215 (adds tmpnet support for antithesis workloads).
Next steps will include ensuring a consistent interface for test invocation to allow reuse of e2e tests in non-ginkgo environments.
How this works
How this was tested
CI