refactor: rename *test.Test* identifiers
#3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested review from
abi87,
StephenButtolph,
danlaine,
dhrubabasu and
joshua-kim
as code owners
ARR4N
requested review from
darioush,
dboehm-avalabs and
ceyonur
as code owners
ARR4N
force-pushed
the
arr4n/stutter-test-pkgs
branch
from
587ef74 to
34d284a
Compare
joshua-kim
approved these changes
Aug 2, 2024
abi87
reviewed
Aug 5, 2024
Comment on lines
+26
to
+29
| // TestState is an alias for State because ava-labs/coreth uses the original | ||
| // identifier and this change would otherwise break the build. | ||
| // | ||
| // Deprecated: use [State]. |
There was a problem hiding this comment.
so there will be a subsequent coreth PR to clean it up, right?
There was a problem hiding this comment.
If I remember. Otherwise this will become lost to the sands of time. But at least nobody else will use it.
abi87
approved these changes
Aug 5, 2024
StephenButtolph
approved these changes
Aug 5, 2024
StephenButtolph
added
testing
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Because Stephen said so. Also https://google.github.io/styleguide/go/decisions#repetition but mainly the former.
How this works
Test*(*testing.T...prefix, in keeping with stdlib fstest, iotest, and slogtest. This signals at the call site that a test is actually being performed. Similarly forBenchmarkandFuzz.Testprefix/suffix elided because they are always referred to by their package-qualified name*test.Thing.tb.Helper()is not added toTest*andBenchmark*functions as this would report the call site as being in the package under test, which isn't useful in debugging.([context.Context], testing.TB, ...)because pedantry.require.Assertionsare changed to accepttesting.TBasrequireis an implementation detail.t.Run(). A failure in one causing others to not run results in whack-a-mole debugging. This may not be comprehensive.All
*testpackages were checked for conformity with the above. Those that have no changes were already compliant.How this was tested
CI