Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve error message of dynamic fee calculations #3297

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Improve error message of dynamic fee calculations #3297

merged 1 commit into from
Aug 15, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

  • These error message improvements were incredibly useful for debugging the dynamic fee implementation.

How this works

  • Adds additional context to returned errors.

How this was tested

  • N/A

@StephenButtolph StephenButtolph added monitoring This primarily focuses on logs, metrics, and/or tracing acp103 labels Aug 15, 2024
@StephenButtolph StephenButtolph added this to the v1.11.11 milestone Aug 15, 2024
@StephenButtolph StephenButtolph self-assigned this Aug 15, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 15, 2024
Merged via the queue into master with commit 9a2aa85 Aug 15, 2024
21 checks passed
@StephenButtolph StephenButtolph deleted the dynamic-fees-improve-errors branch August 15, 2024 10:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ARR4N ARR4N ARR4N approved these changes

@marun marun marun approved these changes

Assignees

@StephenButtolph StephenButtolph

Labels
acp103 monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
Platform Engineering Group
Archived in project
Milestone
v1.11.11
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @marun @ARR4N