Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable Etna by default on local networks #3364

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

michaelkaplan13
Copy link
Contributor

Why this should be merged

When running a local network, the Etna changes should not be activated by default until they are more stable (i.e. activated on Fuji). Otherwise, the local network may break when updating to future AvalancheGo versions.

How this works

Self explanatory

How this was tested

Built and ran /build/avalanchego --network-id=12345. Confirmed activation timestamps using

curl --location 'http://localhost:9650/ext/info' \
--header 'Content-Type: application/json' \
--data '{
    "jsonrpc":"2.0",
    "id"     :1,
    "method" :"info.upgrades"
}'

@michaelkaplan13 michaelkaplan13 marked this pull request as ready for review September 5, 2024 19:21
@michaelkaplan13 michaelkaplan13 force-pushed the disable-etna-by-default-on-local-networks branch from fe1d43c to a90ba87 Compare September 11, 2024 16:05
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm... @ceyonur is this a problematic usage of upgrade.Default here?

// TODO: remove this after Etna and set only the chainID
Config: params.GetChainConfig(upgrade.Default, chainID), // upgrade will be again set by VM according to the snow.Context

@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 11, 2024
Merged via the queue into master with commit 99d2b9a Sep 11, 2024
20 of 21 checks passed
@StephenButtolph StephenButtolph deleted the disable-etna-by-default-on-local-networks branch September 11, 2024 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants