Implement ExpiryEntry #3382
Merged
Implement ExpiryEntry #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
approved these changes
Sep 11, 2024
yacovm
approved these changes
Sep 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Factored out of #3379.
How this works
The expiry map will be stored in memory, but I also think it's important to have a sensible on-disk representation. This could enable future optimizations. Therefore, the on-disk representation is sorted based on when they will be removed. It is not guaranteed or expected for entries to be added based on this order.
How this was tested
MarshalandUnmarshalare bijective.