Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement acp-77 fee configs #3396

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Implement acp-77 fee configs #3396

merged 5 commits into from
Sep 20, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

ACP-77 fees need to be configured for usage during block execution.

How this works

Adds CLI arguments and mainnet/fuji/local default values.

How this was tested

N/A

@StephenButtolph StephenButtolph added this to the v1.11.12 milestone Sep 18, 2024
@StephenButtolph StephenButtolph self-assigned this Sep 18, 2024
ceyonur
ceyonur approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nit

config/flags.go Outdated Show resolved Hide resolved
genesis/genesis_mainnet.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit c6d874b Sep 20, 2024
22 checks passed
@StephenButtolph StephenButtolph deleted the implement-acp-77-config branch September 20, 2024 17:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ceyonur ceyonur ceyonur approved these changes

@marun marun marun approved these changes

Assignees

@StephenButtolph StephenButtolph

Labels
acp77
Projects
Platform Engineering Group
Archived in project
Milestone
v1.11.12
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @marun @ceyonur