Fix node initialization in snowman test #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
changed the title
Comment on lines
78
to
88
| myBlock := &snowmantest.Block{ | ||
| Decidable: snowtest.Decidable{ | ||
| IDV: blk.ID(), | ||
| Status: blk.Status, | ||
| }, | ||
| ParentV: myDep, | ||
| ParentV: blk.ParentV, | ||
| HeightV: blk.Height(), | ||
| VerifyV: blk.Verify(context.Background()), | ||
| BytesV: blk.Bytes(), | ||
| } | ||
| if err := sm.Add(myBlock); err != nil { |
There was a problem hiding this comment.
I think we can simplify this copy further by doing:
copiedBlk := *blk
if err := sm.Add(&copiedBlk); err != nil {The topological consensus tests were supposed to have the instances initialized with a random tree of blocks, where each block points to a random set of descendants. Instead, because of a bug that influenced the parent reference, the blocks were added to the consensus instance as a single block with the rest of the blocks as descendants. That's not what we want to test, so this commit fixes this and further simplifies the initialization logic. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
StephenButtolph
approved these changes
Sep 18, 2024
marun
approved these changes
Sep 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The topological consensus tests were supposed to have the instances initialized with a random tree of blocks, where each block points to a random set of descendants.
Instead, because of a bug that influenced the parent reference, the blocks were added to the consensus instance as a single block with the rest of the blocks as descendants.
That's not what we want to test, so this commit fixes this and further simplifies the initialization logic.
How this works
Properly sets the parent of the block.