Ensure slices are zeroed #3407
Merged
Ensure slices are zeroed #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Sep 20, 2024
| s[i] = *new(T) | ||
| } | ||
| func Zero[T any]() (_ T) { | ||
| return | ||
| } |
There was a problem hiding this comment.
No clue why we had this and it was never used... weird
yacovm
approved these changes
Sep 20, 2024
tsachiherman
approved these changes
Sep 20, 2024
marun
approved these changes
Sep 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Golang can only GC the memory if there are no remaining references to it. Because it's possible to re-extend slices, the memory doesn't get GCed.
How this works
Uses
clear(and deletes theZeroSlicehelper).How this was tested
N/A