Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove mocked iterator #3417

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Remove mocked iterator #3417

merged 1 commit into from
Sep 25, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

While not all mocks are bad - these are. 🧹

How this works

  • Uses real iterator implementations rather than mocked implementations.
  • Deletes the mocked iterator implementation.

How this was tested

  • CI

@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Sep 25, 2024
@StephenButtolph StephenButtolph added this to the v1.11.12 milestone Sep 25, 2024
@StephenButtolph StephenButtolph self-assigned this Sep 25, 2024
ARR4N
ARR4N approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not all mocks are bad

Such diplomacy

@StephenButtolph StephenButtolph merged commit 2ebcde4 into master Sep 25, 2024
21 of 22 checks passed
@StephenButtolph StephenButtolph deleted the remove-mocked-iterator branch September 25, 2024 22:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@ARR4N ARR4N ARR4N approved these changes

@marun marun Awaiting requested review from marun marun is a code owner

Assignees

@StephenButtolph StephenButtolph

Labels
cleanup Code quality improvement
Projects
Platform Engineering Group
Archived in project
Milestone
v1.11.12
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @ARR4N @michaelkaplan13