Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change misleading protobuf comments #3435

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

yacovm
Copy link
Contributor

@yacovm yacovm commented Oct 1, 2024

Why this should be merged

Changed the misleading comment in the protobuf message.

The fields is are hashes / block IDs, not blocks.

Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
@yacovm yacovm force-pushed the changemisleadingproto branch from 1015462 to 5f7824b Compare October 1, 2024 19:15
@yacovm yacovm changed the title Change misleading protobuf comment Change misleading protobuf comments Oct 1, 2024
@StephenButtolph StephenButtolph added the documentation Improvements or additions to documentation or examples label Oct 1, 2024
@StephenButtolph StephenButtolph added this to the v1.11.12 milestone Oct 1, 2024
@StephenButtolph StephenButtolph merged commit e569bb0 into ava-labs:master Oct 2, 2024
22 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation or examples
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants